theme-check icon indicating copy to clipboard operation
theme-check copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

Add a new VariableName check

Open Darhazer opened this issue 2 years ago • 5 comments

Following https://github.com/Shopify/theme-check/issues/64 this check requires that variable names use snake_case

This is my first theme check so any feedback is welcome. As a learning exercise, I intend to do ~all~ most of the checks suggested in #64 so if anything there is outdated, I'd appreciate updating.

Darhazer avatar Feb 22 '23 17:02 Darhazer

@Darhazer This PR dead? 😢

madsenmm avatar Jan 05 '24 10:01 madsenmm

@tmmgrafikr seems to me theme-check is not really maintained.

Darhazer avatar Jan 05 '24 11:01 Darhazer

@tmmgrafikr seems to me theme-check is not really maintained.

Do you use this custom check yourself?

madsenmm avatar Jan 05 '24 13:01 madsenmm

I'm not using theme-check at the moment. I was just interested in the project from the perspective of being a linter for liquid templates

Darhazer avatar Jan 05 '24 13:01 Darhazer

Created an update PR of this here: https://github.com/Shopify/theme-tools/pull/359

madsenmm avatar May 17 '24 12:05 madsenmm

👋🏻 Hi all, given that the theme-tools update that does this has been merged, I'm going to be closing this PR. This repository is no longer maintained. Thank you for your contributions!

lukeh-shopify avatar Jul 27 '24 00:07 lukeh-shopify