theme-check-vscode icon indicating copy to clipboard operation
theme-check-vscode copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

Autocomplete, Autoclose and code suggestion not working!

Open QuintinS opened this issue 1 year ago • 3 comments

Hi all, so I've been trying for a few hours to get the autocomplete, autoclose and autosuggestion working, but with no luck.

Oddly, linting seems to be working just fine (I'm getting code highlighting in VSCode when there's a syntax error / suggestion) but no autocompletion features are working at all.

So far I've:

  • Updated to MacOS Ventura.
  • Uninstalled and reinstalled the Shopify CLI via Homebrew (I'm on version 3)
  • Deleted VSCode and all extension/app data. (fresh install)

Here's a gif of what I'm seeing: voltage--elate-1680529027080

Any idea what might be going wrong here?

Thanks in advance!

QuintinS avatar Apr 03 '23 13:04 QuintinS

Same here. I get suggestions for schema settings but no suggestions for render, include, {% for %}, etc.

Made sure all my cli tools are updated, manually specified the binary paths in the vscode settings, and tried with a fresh vscode profile. The extension seems to be very hit or miss.

adrianocr avatar Apr 06 '23 22:04 adrianocr

I'm seeing the same thing in 1.9.7 - the tag name is suggested for autocomplete but hitting tab or selecting it from the list only completes the tag name (ie if, liquid, etc)

Screen Shot 2023-04-13 at 11 22 32

thelornenelson avatar Apr 13 '23 18:04 thelornenelson

I spent the evening digging around in this extension and the theme-check language server. I've only worked with Textmate-style extensions before, so it took a while to get familiar with language servers and how they work in VS Code.

Anyhow, it doesn't appear that this extensions has autocomplete support as we've gotten used to with other liquid extensions. It does offer completion for tag and filter names, as well as object names and properties (cool!), but it won't autocomplete an entire tag or sequence of tags like we're used to. For now, you'll need to keep using a separate extension to provide those autocomplete snippets for you.

I'm going to continue looking at this extension to see if and how it makes sense to write snippet support for it, but until then I'll just reinstall the other liquid extension I was using to get snippet support back.

timdmackey avatar May 01 '23 05:05 timdmackey

👋 this repo is no longer the source of truth for theme check, if this is still an issue please open an issue in the theme tools repo 🙏 thank you!

mgmanzella avatar Jun 18 '24 17:06 mgmanzella