theme-check-vscode icon indicating copy to clipboard operation
theme-check-vscode copied to clipboard

Version 1.9.7 can't see theme-check-language-server

Open piotrjoniec opened this issue 1 year ago • 3 comments

OS: WSL Ubuntu 20.04

After updating to version 1.9.7, I get this error:

image

I verified it and the theme-check-language-server script does in fact exist under that path. I tried specifying different paths with the "shopifyLiquid.languageServerPath" setting, but the error persists. It seems like checking for the file's existence is somehow broken.

Version 1.9.6 works fine for me.

piotrjoniec avatar Mar 09 '23 14:03 piotrjoniec

Hmm. 1.9.7 prefers theme-check-language-server installs over shopify. So it seems like 1.9.6 works because it wasn't trying that one?

  1. What are the contents of your settings.json?

  2. What is the result of the following command in your terminal?

which theme-check-language-server
  1. What is the result of the following command in your terminal?
which shopify
  1. What are the permissions on those files?
ls $(which theme-check-language-server)
ls $(which shopify)

charlespwd avatar Mar 10 '23 16:03 charlespwd

I'm getting the same issue with the latest version of the VSCode extension (v1.9.7).

  1. I don't have anything set in my settings.json for the extension so all settings are default.
  2. The output of the which theme-check-language-server command is the exact same as the path in the error message
  3. The output confirms the CLI tool is installed at the expected location for the installed version of Node. In my instance /home/username-here/.nvm/versions/node/v19.6.0/bin/shopify. I can confirm the Shopify CLI is on the latest version at the time of this comment (3.44.1)
  4. The permission on theme-check-language-server is 755 (-rwxr-xr-x)

Some further info: I am on the latest version of Windows 11 running Ubuntu 20.04 inside WSL2.
Ruby is installed using rbenv with the global active version being 3.1.0. The Ruby commands are in the path.

The Shopify CLI is installed only within WSL2 as a Linux install and the code is opened in Visual Studio Code via the command-line using code . in the project directory. The Remote Development extensions are installed in VSCode and the Shopify Liquid extension is installed within WSL to ensure it has access to the system.

Since the extension is installed and active the error shows up within any project whether it is a Shopify theme or not.

39digits avatar Mar 23 '23 14:03 39digits

Screenshot from 2023-03-30 17-41-22

Screenshot from 2023-03-30 18-23-24

Screenshot from 2023-03-30 18-24-31

After updating to version 1.9.7 - gives an error.

Working on Ubunta 22 + VScode

The 1.9.7 update works, but keeps showing an error.

Aleksej579 avatar Mar 30 '23 14:03 Aleksej579

👋 this repo is no longer the source of truth for theme check, if this is still an issue please open an issue in the theme tools repo 🙏 thank you!

mgmanzella avatar Jun 18 '24 17:06 mgmanzella