tapioca icon indicating copy to clipboard operation
tapioca copied to clipboard

Drop the `benchmark` dependency

Open Earlopain opened this issue 2 months ago • 3 comments

Motivation

tapioca currently depends on the benchmark gem because of a change to Ruby bundled gems. The functionality is trivial though, and I don't think you have to take on a dependency for that.

Implementation

Just use Process.clock_gettime directly.

Tests

No behaviour change. I just ran some cli commands and they still print the time in seconds. Probably the output is also already asserted against somewhere.

Earlopain avatar Oct 16 '25 10:10 Earlopain

Thanks for the PR. Can you fix typechecking errors?

st0012 avatar Oct 16 '25 11:10 st0012

Oops, yeah

Earlopain avatar Oct 16 '25 11:10 Earlopain

We have addressed a few CI issues this week, which should make this PR's build green. Can you rebase the PR? Thx

st0012 avatar Oct 22 '25 22:10 st0012