spoom icon indicating copy to clipboard operation
spoom copied to clipboard

Do not swallow Sorbet errors

Open Morriar opened this issue 3 years ago • 0 comments

Currently, spoom will swallow any error from Sorbet even if it's not a type checking error.

For example, running this:

spoom tc --sorbet-options="--not-found"

Will fail silently.

To solve the problem we first introduced a new error code in Sorbet so it returns 100 if type checking finished correctly but with type checking errors.

The second step is to make Spoom check this error code so we can relay any non-type checking error to the user.

This also means requiring at least Sorbet 0.5.10187.

Closes https://github.com/Shopify/ruby-dev-exp-issues/issues/602.

Morriar avatar Jul 21 '22 19:07 Morriar