shopify_python
shopify_python copied to clipboard
[WIP] bump pylint
Problem summary:
Currently shopify_python requires pylint ~= 2.1.1. But, pylint
v2.1.* has this dependency issue on 'isort >= 4.2.5
. There's no dependency constraint there, so eventually isort
released v5
. pylint 2.1.1 picks up the new version and breaks.
More recently, pylint 2.6.0
supports isort v5
https://github.com/PyCQA/pylint/pull/3725
This PR relaxes the dependency constraint so shopify_python
will pick up the newer pylint
version.
This PR fixes #114
I tested this by: [ ] pytest locally [ ] push to PyPi test and test fix downstream in Panama CI
Another, lower impact option would be to somehow lock the version of isort
?
Any change we can merge this? My PR is failing because it needs pylint > 2.3.0
https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639
see: https://github.com/conda-forge/pylint-feedstock/issues/29#issuecomment-468970823
Any change we can merge this? My PR is failing because it needs
pylint > 2.3.0
https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639
You could potentially make a branch in this repo, make the fixes you need, then reference the branch name using a suffix in your setuptools or pip requirements.txt, e.g.
git+https://github.com/Shopify/shopify_python.git@your-example-branch
Any change we can merge this? My PR is failing because it needs
pylint > 2.3.0
https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639
I am also seeing this issue in another repo. Is it possible to ship this change to shopify_python
?