shopify_python icon indicating copy to clipboard operation
shopify_python copied to clipboard

[WIP] bump pylint

Open DavidGarfinkle opened this issue 4 years ago • 4 comments

Problem summary:

Currently shopify_python requires pylint ~= 2.1.1. But, pylint v2.1.* has this dependency issue on 'isort >= 4.2.5. There's no dependency constraint there, so eventually isort released v5. pylint 2.1.1 picks up the new version and breaks.

More recently, pylint 2.6.0 supports isort v5 https://github.com/PyCQA/pylint/pull/3725

This PR relaxes the dependency constraint so shopify_python will pick up the newer pylint version.

This PR fixes #114

I tested this by: [ ] pytest locally [ ] push to PyPi test and test fix downstream in Panama CI

DavidGarfinkle avatar Dec 09 '20 20:12 DavidGarfinkle

Another, lower impact option would be to somehow lock the version of isort?

erikwright avatar Dec 09 '20 21:12 erikwright

Any change we can merge this? My PR is failing because it needs pylint > 2.3.0 https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639

see: https://github.com/conda-forge/pylint-feedstock/issues/29#issuecomment-468970823

jessicaxiejw avatar Apr 05 '21 17:04 jessicaxiejw

Any change we can merge this? My PR is failing because it needs pylint > 2.3.0 https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639

You could potentially make a branch in this repo, make the fixes you need, then reference the branch name using a suffix in your setuptools or pip requirements.txt, e.g.

git+https://github.com/Shopify/shopify_python.git@your-example-branch

efung avatar Apr 06 '21 15:04 efung

Any change we can merge this? My PR is failing because it needs pylint > 2.3.0 https://github.com/Shopify/ci-queue/pull/168/checks?check_run_id=2271709639

see: conda-forge/pylint-feedstock#29 (comment)

I am also seeing this issue in another repo. Is it possible to ship this change to shopify_python?

jordansmithnl avatar Jun 24 '22 15:06 jordansmithnl