shopify-app-template-node icon indicating copy to clipboard operation
shopify-app-template-node copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

Improve DockerFile : use node command

Open shaswatsaxena opened this issue 2 years ago • 1 comments

WHY are these changes introduced?

Improved DockerFile according to node docker best practices : https://github.com/goldbergyoni/nodebestpractices/blob/master/sections/docker/bootstrap-using-node.md

WHAT is this pull request doing?

  • Updated the DockerFile to set NODE_ENV to production
  • And use node index.js instead of npm serve

shaswatsaxena avatar Jun 10 '22 04:06 shaswatsaxena

I have signed the CLA but how do I re-run the CLA check on the PR ?

shaswatsaxena avatar Jun 16 '22 03:06 shaswatsaxena