shopify-api-js icon indicating copy to clipboard operation
shopify-api-js copied to clipboard

please upgrade to node-fetch 3.x

Open mariusa opened this issue 3 years ago • 1 comments

https://github.com/Shopify/shopify-node-api/blob/2430848203ed3605e91763be652e7b1f8f37b52a/package.json#L48

The latest version is 3.x, with the major change being that only ESM import is possible now. This library already uses it via import, so it should just work: https://github.com/Shopify/shopify-node-api/blob/c9d94515773745ebd89be226bb6ebab244cf1e62/src/clients/http_client/http_client.ts#L5

mariusa avatar Dec 29 '21 16:12 mariusa

Additionally, the installed version has a high severity vulnerability https://github.com/advisories/GHSA-r683-j2x4-v87g

tbeseda avatar Jan 23 '22 04:01 tbeseda

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] avatar Oct 06 '22 02:10 github-actions[bot]

not stale

mariusa avatar Oct 06 '22 06:10 mariusa

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] avatar Jan 31 '23 02:01 github-actions[bot]

still valid

mariusa avatar Jan 31 '23 16:01 mariusa

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] avatar Apr 03 '23 01:04 github-actions[bot]

not stale

mariusa avatar Apr 03 '23 08:04 mariusa

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] avatar Jun 03 '23 02:06 github-actions[bot]

...

mariusa avatar Jun 03 '23 08:06 mariusa

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] avatar Aug 04 '23 01:08 github-actions[bot]

We are closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

github-actions[bot] avatar Aug 19 '23 01:08 github-actions[bot]