shopify-api-js icon indicating copy to clipboard operation
shopify-api-js copied to clipboard

Add private app webhook validation support

Open ynynl opened this issue 3 years ago • 2 comments

Overview

Support private app webhooks validation.

Type

  • [ ] New feature
  • [x] Changes to existing features

Motivation

What inspired this feature request? What problems were you facing?

The current webhook registry doesn't validate request through share secret as in the private app.

Area

  • [ ] Add any relevant Area: <area> labels to this issue

Checklist

  • [ ] I have described this feature request in a way that is actionable (if possible)

ynynl avatar Sep 17 '21 04:09 ynynl

Is there any update on using private app validation with this module?

dturton avatar Nov 05 '21 19:11 dturton

Is there any update on using private app validation with this module?

I did a simple workaround to run my project, if you need it:

  Shopify.Context.API_SECRET_KEY = SHARED_SECRET // Use shared secret to validate web hook in private app.
  await Shopify.Webhooks.Registry.process(req, res);
  Shopify.Context.API_SECRET_KEY = API_SECRET_KEY // Change back to API secret key.

ynynl avatar Nov 05 '21 21:11 ynynl

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

github-actions[bot] avatar Oct 06 '22 02:10 github-actions[bot]

We are closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

github-actions[bot] avatar Oct 20 '22 02:10 github-actions[bot]