shopify-api-js icon indicating copy to clipboard operation
shopify-api-js copied to clipboard

Managed Installation is broken when reinstalling from Admin's Settings.

Open kinngh opened this issue 1 year ago • 2 comments

Issue summary

When trying to reinstall the app that's using managed installation via Admin's Apps and sales channels settings' uninstall tab, the app fails to install. Confirmed with 4 other devs using managed installation and is reproducible.

  • @shopify/shopify-api version: 9.0.2
  • Node version: 21.6.1
  • Operating system: macOS 14.3.1

Expected behavior

The app installs on the store and shows up in the Apps and sales channels list

Actual behavior

Redirected to a 404 page in admin

Steps to reproduce the problem

  1. Use Shopify managed installation in your app and push your toml file to sync config
  2. Install the app via the partner dashboard
  3. Uninstall the app from the store
  4. Head into settings > apps and sales channel
  5. Head into the uninstalled tab
  6. Find your app and click on install

Video:

https://github.com/Shopify/shopify-api-js/assets/773555/b4a8208e-b4d8-495e-aa1c-b2c69a46948c

kinngh avatar Feb 09 '24 17:02 kinngh

Hi there 👋

The team that manages app install flow is aware of this issue, and they have some folks looking into it!

lizkenyon avatar Feb 14 '24 19:02 lizkenyon

@lizkenyon thank you for the update!

kinngh avatar Feb 14 '24 20:02 kinngh

Hi @lizkenyon! Thank you for posting the update. Is there any new development on this? :-)

dev-prakhar avatar Feb 21 '24 14:02 dev-prakhar

A member of the team that manages app install flow with post on this issue with updates when it has been resolved! :)

lizkenyon avatar Feb 21 '24 14:02 lizkenyon

Hey everyone 👋 !, The fix has been shipped to production. Please, let me know if it's working for you.

alvaro-shopify avatar Feb 23 '24 14:02 alvaro-shopify

@alvaro-shopify I can confirm that it is working for me! 🎉🎉🎉

dev-prakhar avatar Feb 23 '24 14:02 dev-prakhar

@alvaro-shopify can confirm this works as expected on fresh and existing apps - thank you so much for the fix! Closing the issue^

kinngh avatar Feb 23 '24 15:02 kinngh

@alvaro-shopify this seems to be working fine on the web but still randomly getting issues when inside the Shopify iOS and Android apps.

IMG_6152

fersk avatar Mar 26 '24 16:03 fersk