ruby-style-guide icon indicating copy to clipboard operation
ruby-style-guide copied to clipboard

Only build on `push`, not on `pull_request` too

Open sambostock opened this issue 4 years ago • 2 comments

Listening for both events triggers a redundant build. All PRs will have involved pushing a branch, so the build will have already been triggered. There is no need to trigger it again.

sambostock avatar Feb 10 '21 19:02 sambostock

This is a public repo. For external contributors, their pushes don't go to this repo, they go to their own clone, and so don't trigger CI. Once they open a PR on our repo, the PR triggers CI. For internal developers, builds on push are convenient to see failures before opening a PR.

lugray avatar Feb 10 '21 19:02 lugray

Here is how I accomplished this in the public identity_cache repo: https://github.com/Shopify/identity_cache/commit/4a55be5b81c4190d3aeb85534ed44977a05df912

dylanahsmith avatar Feb 11 '21 16:02 dylanahsmith