Shopify
Add associations on Rails Models for Hover
A few more suggestions after talking with the team:
- Rather than pushing line by line to
@response_builder, let's build up the full string first, then we just need one call. It will probably help to extract a private method for this. - Let's avoid the
nbspcharacters in the markdown. Even thought it may look ok in VS Code, this has to work in other editors too, so we shouldn't assume too much about how it gets rendered. - Using
heredocs rather the concatenating strings may improve readability.
Small suggestion after trying on a large model with many assocations: We could sort the list alphabetically within each 'group' (e.g. has_many).
A few more suggestions after talking with the team:
- Rather than pushing line by line to
@response_builder, let's build up the full string first, then we just need one call. It will probably help to extract a private method for this.- Let's avoid the
nbspcharacters in the markdown. Even thought it may look ok in VS Code, this has to work in other editors too, so we shouldn't assume too much about how it gets rendered.- Using
heredocs rather the concatenating strings may improve readability.
I will see when I can get to all these. Probably won't be until late this week now. I am quite busy at work right now but will get it done ASAP.
:wave: @rickcaudill
At RailsConf next week, there is going to be Hack Days session for Ruby LSP Rails.
Would you be ok with other people contributing to this PR to help complete it?
👋 @rickcaudill
At RailsConf next week, there is going to be Hack Days session for Ruby LSP Rails.
Would you be ok with other people contributing to this PR to help complete it?
Actually I was going to get to this this weekend. If I don't happen to I would appreciate some help. I have another one as well that I'm working on. The reason why its slow is because I'm in the middle of a big push at work and working with some additional clients right now. However I was planning to try to get this done this weekend. My team uses visual studio code as an IDE so these changes are quality of life changes for my team.