react-native-skia icon indicating copy to clipboard operation
react-native-skia copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

iOS: Add support for Fabric / new architecture

Open chrfalch opened this issue 2 years ago • 5 comments

Since we're now on version 0.68 of the example project we should add support for the new architecture / Fabric in our library as well. This should be done so that we can use the library both with and without Fabric.

chrfalch avatar Apr 10 '22 09:04 chrfalch

image i think it's related to this issue. steps:

  1. react-native init skia
  2. ios/Podfile: :hermes_enabled => true, :fabric_enabled => true,
  3. USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 pod install
  4. try to build iOS app

skurgansky-sugarcrm avatar Jun 30 '22 14:06 skurgansky-sugarcrm

@skurgansky-sugarcrm - This issue is still open and not implemented so this is not expected to work yet.

chrfalch avatar Jul 01 '22 06:07 chrfalch

I tried to use this library along with RNGH and Fabric but my app crash and close on every init. So this is why, right?

hadnet avatar Jul 03 '22 17:07 hadnet

I can find any mentioning about Fabric support neither in docs nor in open PR. Do you have any open issue about that to follow them?

skurgansky-sugarcrm avatar Jul 08 '22 09:07 skurgansky-sugarcrm

This project has not yet been converted to support Fabric, this issue is for tracking the conversion. It will be closed when we've finalised this functionality.

chrfalch avatar Jul 08 '22 14:07 chrfalch

Is there an ETA for adding Fabric support to Skia?

maciej-lepb avatar Mar 05 '23 20:03 maciej-lepb

Hi there. Using RN0.72.0-rc.3, Skia 0.1.189, react-native-reanimated 3.1.0 on iOS and app is working well. However, when I switch the new architecture on via RCT_NEW_ARCH_ENABLED="1" then I get a build failure in Skia:

Screenshot 2023-05-12 at 20 07 48

Any idea why this may be?

dpyeates avatar May 12 '23 19:05 dpyeates

Totally understand this project has a lot of moving parts and paying supporters get priority, as has been stated already.

Having said that, for teams wanting to adopt the new arch, could a maintainer weigh-in on what a timeline for RN Skia supporting it may be?

Weeks? Months? Years?

Just so we can move forward with using it or not :) Thanks.

kylegillen avatar Aug 03 '23 16:08 kylegillen

Hi @nextriot - valid question and an important discussion :)

I think that the issue we've had with the new architecture has been that we've tried this conversion a few times on the different RN versions supporting Fabric - and each time we've see relatively big changes coming in each new version forcing us to update and spend time on this. Lastly in RN 0.72 we got the new Interop layer that should help doing this automatically for legacy components - Fabric / new architecture is still also marked as experimental so we expect changes also in upcoming versions.

Having said all this we definitely want to support Fabric - but due to both low adoption (I know adding support might help on that) and relatively low number of requests compared to other things on our plans we've had to push this feature a bit.

We're open to contributions for direct features like implementing support for Fabric - so if you either want to help creating PRs implementing the feature or want to discuss sponsoring this as a short project you're more than welcome to do so.

chrfalch avatar Aug 04 '23 06:08 chrfalch

Can I know if there is any progress on this?

sumitmanral avatar Oct 07 '23 10:10 sumitmanral

Can I know if there is any progress on this?

okaybeydanol avatar Oct 23 '23 13:10 okaybeydanol

I think skia is the last blocker for our app to use the new architecture. Unfortunately I have no cpp experience so I'm unlikely to be able to meaningfully contribute to solving this in the near term. Hopefully the talented people here will be able to tackle this soon 😄

@chrfalch I see there's a PR already open for this, is there a blocker to merging that?

evelant avatar Oct 26 '23 20:10 evelant