react-native-skia icon indicating copy to clipboard operation
react-native-skia copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

.clang-format configuration

Open schiller-manuel opened this issue 2 years ago • 3 comments

I just ran yarn clang-format and it reformatted over 50 files. I assume this is caused by the fact that this project does not contain a .clang-format file; so the default config of my installed clang-format binary (13.0.1) kicked in. Do you have a .clang-format file already?

schiller-manuel avatar Mar 22 '22 21:03 schiller-manuel

We should make sure that yarn clang-format is run on the CI correct? like we do for the TS code?

wcandillon avatar Mar 22 '22 21:03 wcandillon

Yes, it should run in CI. But the code format configuration should also be specified explicitly and not depend on the version of clang-format that is installed, since it may be different from e.g. CI and dev computer.

schiller-manuel avatar Mar 22 '22 21:03 schiller-manuel

Agree, @schiller-manuel! Anyone want to try to add this? PRs are welcome :)

chrfalch avatar Mar 23 '22 11:03 chrfalch

We fixed/merged that a while back already :)

wcandillon avatar Nov 18 '22 12:11 wcandillon