react-native-skia icon indicating copy to clipboard operation
react-native-skia copied to clipboard

Passing of props on WithSkiaWeb

Open nathan-ahn opened this issue 1 year ago • 1 comments

As far as I can tell, there was previously no good way to pass props directly into the component loaded by WithSkiaWeb. This pull request adds a typed componentProps field that's forwarded to the result of getComponent. It matches the types of the corresponding component, and if there's any required fields, componentProps itself is required. I believe this covers the full breadth of type-safety.

This pull request does swap WithSkiaProps from being an interface to being a type. This shouldn't cause any issues, but if there's a strong preference for an interface here I can investigate other solutions.

nathan-ahn avatar Mar 28 '24 21:03 nathan-ahn

What's required to get this merged?

avaziman avatar Jul 27 '24 15:07 avaziman

+1 To the ask for this feature! Is there a short-term plan to merge it?

btw, thanks for you hard work! @wcandillon

santitopo avatar Sep 12 '24 13:09 santitopo

super seeded by #2662 we will release this asap. Hopefully today.

wcandillon avatar Sep 30 '24 14:09 wcandillon