react-native-skia icon indicating copy to clipboard operation
react-native-skia copied to clipboard

Add support for view snapshots on Fabric

Open wcandillon opened this issue 1 year ago • 1 comments

Description

Tags are not supported by Fabric: https://reactnative.dev/docs/0.70/new-architecture-library-intro#migrating-findnodehandle--getting-a-hostcomponent

We need to update the code for this feature to work on fabric.

wcandillon avatar Nov 24 '23 05:11 wcandillon

Hi @wcandillon , When we can expect it? This below code is working fine only in iOS with Fabric. const newSnap = await makeImageFromView(lineRef);

I was using view shot library for this but same tag issue is there as I have raised almost 9 months ago but no update yet. Here is this link: https://github.com/gre/react-native-view-shot/issues/469 No one is replying there about fix.

Then today I switched to RNSkia and it's working fine for iOS with Fabric but not for Android. For Android it's giving same error like view not found. Can you fix it in RNSkia so we can continue well with our image sharing apps? It will be really appreciated.

Thanks. Er Harinder Singh.

ErHarinderSingh avatar Dec 16 '23 14:12 ErHarinderSingh

Any updates on this?

L0rdCr1s avatar Mar 14 '24 15:03 L0rdCr1s

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Apr 11 '24 06:04 github-actions[bot]