polaris icon indicating copy to clipboard operation
polaris copied to clipboard

Fix issue with popovers not working in embedded app modals when put inside of a details component

Open vividviolet opened this issue 1 year ago • 3 comments

Enable popover display state to be updated based on the parent's resize event.

https://github.com/user-attachments/assets/7702a0bc-88ef-4e01-8043-1239562c609c

WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris/pull/12445#issuecomment-2275760015

WHAT is this pull request doing?

Attach the resize observer to the parent element of the activator when available instead of the activator itself.

How to 🎩

🖥 Local development instructions 🗒 General tophatting guidelines 📄 Changelog guidelines

🎩 checklist

vividviolet avatar Aug 10 '24 02:08 vividviolet

/snapit

vividviolet avatar Aug 10 '24 02:08 vividviolet

🫰✨ Thanks @vividviolet! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20240810023129"

github-actions[bot] avatar Aug 10 '24 02:08 github-actions[bot]

Thanks for working on that :). However it does not seem to work if the popover is nested in a div inside the details.

bakura10 avatar Aug 10 '24 08:08 bakura10

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

github-actions[bot] avatar Feb 07 '25 03:02 github-actions[bot]