liquid icon indicating copy to clipboard operation
liquid copied to clipboard

change: make nil_safe_casecmp judge compatible for nil-nil comparison

Open mtasaka opened this issue 1 year ago • 3 comments

Ruby returns 0 (not nil) for nil <=> nil, i.e. nil and nil are judged as equal for comparison, and so returns nil_safe_compare . ref: https://github.com/Shopify/liquid/pull/1476

To make the behavior of nil_safe_casecmp consistent with nil_safe_compare , change nil_safe_casecmp so that comparison between nil <=> nil return 0 (equal).

Also change testsuite to reflect this change.

Fixes #1759 .

mtasaka avatar Nov 26 '23 07:11 mtasaka

This makes sense to me and seems like the correct behavior. @samdoiron thoughts?

ianks avatar Dec 09 '23 22:12 ianks

@mtasaka I think there is a linting failure in CI

ianks avatar Dec 10 '23 16:12 ianks

@mtasaka I think there is a linting failure in CI

@ianks I've force-pushed my PR with indentation fixed. Would you recheck this?

mtasaka avatar Dec 15 '23 06:12 mtasaka