liquid icon indicating copy to clipboard operation
liquid copied to clipboard

Snippet generates extra unnecessary comments

Open its-anas opened this issue 2 years ago • 2 comments

  1. I want to use a snippet that converts hex to rgba:
<!-- color_to_rgba.liquid -->
{%- 
  liquid
  assign rgb = color | color_to_rgb
  assign tail = opacity | prepend: ', ' | append: ')' 
-%}
{{ rgb | replace: 'rgb', 'rgba' | replace: ')', tail }}
  1. And it should returns the output so i can use it inside page CSS:
<!-- page.liquid -->
<style>
    --converted-rgba-color: {{% render 'color_to_rgba', color: '#000', opacity: '0.5' %}}
</style>
  1. But instead of getting only the output, there is extra 2 wrapping comments i'm unable to get rid of:
<style>
    --converted-rgba-color: <!-- BEGIN app snippet: test -->rgba(0, 0, 0, 0.5)<!-- END app snippet -->
</style>

its-anas avatar Apr 12 '23 04:04 its-anas

Can these comments be removed?

It makes it impossible to create a snippet that returns JavaScript code.

At this time, we have to treat all snippets as HTML output.

thosakwe avatar Mar 03 '24 16:03 thosakwe

Had the same issue and reached here, if anyone encounters the same issue, I've used the strip_html filter to remove those comments

{% capture content %}{% render 'some-snippet'%}{% endcapture %}
<style>
    {{ content | strip_html }}
</style>

ShlomiAmichay avatar Jul 31 '24 11:07 ShlomiAmichay