krane icon indicating copy to clipboard operation
krane copied to clipboard

uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState

Open bcha opened this issue 3 years ago • 5 comments

Bug report

krane blows up on deploy since last night. Possibly related to Rails 7.0.0 release? See similar: https://github.com/rails/rails/issues/43889

-> Need to require top level active_support in krane too? I'm not too familiar with Ruby or gem myself.

Expected behavior: krane doesnt blow up

Actual behavior: krane blows up

Version(s) affected: Both 2.3.0 & 2.3.4 are affected.

Steps to Reproduce

Run krane deploy:

$ krane deploy ${NAMESPACE} ${KUBE_CONTEXT} -f ./k8s/overlays/${ENVIRONMENT}/kustomized/${ENVIRONMENT}.yml --global-timeout=${KRANE_GLOBAL_TIMEOUT} ${KRANE_EXTRA_ARGS}
/usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:184:in `current_thread_backend': uninitialized constant ActiveSupport::XmlMini::IsolatedExecutionState (NameError)
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:103:in `backend='
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:201:in `<module:ActiveSupport>'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/xml_mini.rb:11:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/core_ext/array/conversions.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/duration.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/activesupport-7.0.0/lib/active_support/core_ext/numeric/time.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane/common.rb:6:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane/deploy_task.rb:8:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane.rb:3:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/lib/krane/cli/krane.rb:2:in `<top (required)>'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require'
	from /usr/local/bundle/gems/krane-2.3.0/exe/krane:4:in `<top (required)>'
	from /usr/local/bundle/bin/krane:23:in `load'
	from /usr/local/bundle/bin/krane:23:in `<main>'

bcha avatar Dec 16 '21 08:12 bcha

We worked around this issue by explicitly installing older activesupport before krane in our dockerfiles:

...
    gem install activesupport -v 6.1.4.3 && \
    gem install krane:2.3.4

Seems to work fine as a workaround, dunno if there are any fun side-effects.

bcha avatar Dec 16 '21 09:12 bcha

The blew up our updates as well. I consider it a critical issue because it breaks clean installs of krane.

ibratoev avatar Jan 11 '22 07:01 ibratoev

I just want to voice my support for this. It broke our deployments after update of shipit-engine. krane is not usable with activesupport 7.

sonalkr132 avatar Apr 17 '22 03:04 sonalkr132

Isn't https://github.com/Shopify/krane/pull/861 fixing this?

simi avatar Apr 17 '22 09:04 simi

@simi Indeed. Y'all just need to upgrade krane. This issue can be closed.

benlangfeld avatar May 02 '22 18:05 benlangfeld