hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

whitespace-only changes to an existing changeset

Open kdaviduik opened this issue 3 months ago • 2 comments

WHY are these changes introduced?

This Graphite stack of PR consists of the changes in https://github.com/Shopify/hydrogen/pull/3169, but easier to review and split up into multiple PRs.

I created this by:

  1. Resetting (hard) all commits on main since this PR was merged
  2. Resetting (soft) this PR's merge commit
  3. Ran npm run review-recipe-diffs introduced in this PR
    • I cherry-picked the commit, ran the scripts, then deleted the changes from that commit (ie: the changes from that commit/PR aren't present in this Graphite stack)
Examples -> recipes migration summary. table + info

Recipe Conversion Summary

This table shows all recipes after applying the changes on the current branch.

Recipe Name Pre-existing Original Example Name Notes
b2b No b2b Converted from example
bundles Yes - Pre-existing recipe
combined-listings Yes - Pre-existing recipe
custom-cart-method No custom-cart-method Converted from example
express No express Converted from example
gtm No gtm Converted from example
infinite-scroll No infinite-scroll Converted from example
legacy-customer-account-flow No legacy-customer-account-flow Converted from example
markets Yes - Pre-existing recipe
metaobjects No metaobjects Converted from example
multipass No multipass Converted from example
partytown No partytown Converted from example
subscriptions Yes - Pre-existing recipe (but also had an example with same name)
third-party-api No third-party-queries-caching Renamed during conversion

Summary

  • Total recipes: 14
  • Pre-existing recipes: 4 (bundles, combined-listings, markets, subscriptions)
  • New recipes from examples: 10
  • Renamed during conversion: 1 (third-party-queries-caching → third-party-api)

Notes

  • The subscriptions recipe was pre-existing, but there was also an example with the same name that was deleted
  • The third-party-queries-caching example was renamed to third-party-api when converted to a recipe
  • All other converted examples retained their original names as recipes

kdaviduik avatar Sep 25 '25 23:09 kdaviduik