hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

[BuyerAuthentication] if shopId is passed, use the core url

Open s-lee-kwong opened this issue 1 year ago • 10 comments

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • [x] I've read the Contributing Guidelines
  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've added a changeset if this PR contains user-facing or noteworthy changes
  • [x] I've added tests to cover my changes
  • [x] I've added or updated the documentation

s-lee-kwong avatar Aug 15 '24 14:08 s-lee-kwong

Oxygen deployed a preview of your slk/core-auth-in-prod branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
metaobjects ❌ Error (Logs) - Inspect deployment September 24, 2024 7:56 PM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:53 PM

Learn more about Hydrogen's GitHub integration.

shopify[bot] avatar Aug 15 '24 14:08 shopify[bot]

/snapit

s-lee-kwong avatar Aug 15 '24 18:08 s-lee-kwong

🫰✨ Thanks @s-lee-kwong! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/mini-oxygen": "0.0.0-snapshot-20240815183308"

github-actions[bot] avatar Aug 15 '24 18:08 github-actions[bot]

/snapit

s-lee-kwong avatar Aug 19 '24 16:08 s-lee-kwong

/snapit

wizardlyhel avatar Aug 19 '24 17:08 wizardlyhel

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset. If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG. If you are making simple updates to examples or documentation, you do not need to add a changeset.

github-actions[bot] avatar Aug 19 '24 18:08 github-actions[bot]

/snapit

s-lee-kwong avatar Aug 21 '24 12:08 s-lee-kwong

🫰✨ Thanks @s-lee-kwong! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20240821120310",
"@shopify/hydrogen": "0.0.0-snapshot-20240821120310",
"@shopify/mini-oxygen": "0.0.0-snapshot-20240821120310"

Create a new project with all the released packages running npm create @shopify/hydrogen@<snapshot_version> To try a new CLI plugin version, add @shopify/cli-hydrogen as a dependency to your project using the snapshot version.

github-actions[bot] avatar Aug 21 '24 12:08 github-actions[bot]

/snapit

s-lee-kwong avatar Aug 21 '24 13:08 s-lee-kwong

🫰✨ Thanks @s-lee-kwong! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20240821132307",
"@shopify/hydrogen": "0.0.0-snapshot-20240821132307",
"@shopify/mini-oxygen": "0.0.0-snapshot-20240821132307"

Create a new project with all the released packages running npm create @shopify/hydrogen@<snapshot_version> To try a new CLI plugin version, add @shopify/cli-hydrogen as a dependency to your project using the snapshot version.

github-actions[bot] avatar Aug 21 '24 13:08 github-actions[bot]