hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Single Fetch Example

Open michenly opened this issue 1 year ago • 2 comments

WHY are these changes introduced?

This PR aims to try out Remix's Single Fetch featureahead of the release for React Router v7/Remix v3

Close https://github.com/Shopify/hydrogen-internal/issues/108

WHAT is this pull request doing?

Created an unstable example for those who want to try out remix's single fetch with Hydrogen ahead of React Router v7.

  • Turn on single fetch feature flag
  • import single fetch type
  • add nonce to <RemixServer />
  • turn on cd's compatibility flag for http_headers_getsetcookie => need to make this configurable

HOW to test your changes?

Post-merge steps

Checklist

  • [ ] I've read the Contributing Guidelines
  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've added a changeset if this PR contains user-facing or noteworthy changes
  • [ ] I've added tests to cover my changes
  • [ ] I've added or updated the documentation

michenly avatar May 28 '24 20:05 michenly

Oxygen deployed a preview of your mc-single-fetch branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 30, 2024 9:39 PM
optimistic-cart-ui ❌ Error (Logs) - Inspect deployment August 5, 2024 4:17 PM
Skeleton (skeleton.hydrogen.shop) ❌ Error (Logs) - Inspect deployment August 5, 2024 4:17 PM

Learn more about Hydrogen's GitHub integration.

shopify[bot] avatar May 28 '24 20:05 shopify[bot]

Blocked by Oxygen runtime to upgrade to latest Cloudflare compatibility date and compatibility flags Issue link

michenly avatar May 30 '24 17:05 michenly

Close since the single fetch implementation are changing and this PR will no longer apply

michenly avatar Aug 06 '24 15:08 michenly