Refactor: move classic compiler code
- Merge
dev-viteanddevcommands - Merge
build-viteandbuildcommands - Move classic compiler code to
lib - Split
init.test.tsin different files - Minor fixes to
--quickstart - Cleanup code related to the
--stylingflag
🎩 : Nothing should change in behavior, except for the minor fixes.
Oxygen deployed a preview of your fd-move-classic-compiler-code branch. Details:
| Storefront | Status | Preview link | Deployment details | Last update (UTC) |
|---|---|---|---|---|
| vite | ✅ Successful (Logs) | Preview deployment | Inspect deployment | May 7, 2024 4:47 AM |
| custom-cart-method | ❌ Error (Logs) | - | Inspect deployment | May 7, 2024 4:49 AM |
| subscriptions | ✅ Successful (Logs) | Preview deployment | Inspect deployment | May 7, 2024 4:47 AM |
| third-party-queries-caching | ✅ Successful (Logs) | Preview deployment | Inspect deployment | May 7, 2024 4:47 AM |
| skeleton | ✅ Successful (Logs) | Preview deployment | Inspect deployment | May 7, 2024 4:47 AM |
| optimistic-cart-ui | ✅ Successful (Logs) | Preview deployment | Inspect deployment | May 7, 2024 4:47 AM |
Learn more about Hydrogen's GitHub integration.
I'm afraid this is related to the new global CLI 🤔
Yeah, this is happening as well in main branch and it's related to the new CLI 3.59.2 being incompatible with --diff: https://github.com/Shopify/cli/blob/9f66320f3d56f69e3d77d173a0eca31cc7fc9f96/packages/cli/src/hooks/init.ts#L10
I'll try to find a workaround in another branch -- https://github.com/Shopify/hydrogen/pull/2075
We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.