hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Refactor: move classic compiler code

Open frandiox opened this issue 1 year ago • 1 comments

  • Merge dev-vite and dev commands
  • Merge build-vite and build commands
  • Move classic compiler code to lib
  • Split init.test.ts in different files
  • Minor fixes to --quickstart
  • Cleanup code related to the --styling flag

🎩 : Nothing should change in behavior, except for the minor fixes.

frandiox avatar Apr 15 '24 12:04 frandiox

Oxygen deployed a preview of your fd-move-classic-compiler-code branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 4:47 AM
custom-cart-method ❌ Error (Logs) - Inspect deployment May 7, 2024 4:49 AM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 4:47 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 4:47 AM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 4:47 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 4:47 AM

Learn more about Hydrogen's GitHub integration.

shopify[bot] avatar Apr 15 '24 12:04 shopify[bot]

I'm afraid this is related to the new global CLI 🤔

frandiox avatar May 01 '24 23:05 frandiox

Yeah, this is happening as well in main branch and it's related to the new CLI 3.59.2 being incompatible with --diff: https://github.com/Shopify/cli/blob/9f66320f3d56f69e3d77d173a0eca31cc7fc9f96/packages/cli/src/hooks/init.ts#L10

I'll try to find a workaround in another branch -- https://github.com/Shopify/hydrogen/pull/2075

frandiox avatar May 02 '24 04:05 frandiox

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset. If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG. If you are making simple updates to examples or documentation, you do not need to add a changeset.

github-actions[bot] avatar May 07 '24 04:05 github-actions[bot]