hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Adding transition (concurrent) to route changes 🎉

Open sanjaiyan-dev opened this issue 3 years ago • 5 comments

This PR is heavily inspired from new Next js Layout RFC.

This update would improve Interaction on Next Paint and uses new concurrent feature :)

Sorry if I made any mistakes :(

sanjaiyan-dev avatar Aug 11 '22 12:08 sanjaiyan-dev

Been testing this. Just a few comments on the PR. More generally, it looks like your change also updates our formatting. Could you please format with yarn run format?

I am extremely sorry I used GitHub we based editor so I don't have access to CLI 🥹 Can you please help me with it :) @blittle

sanjaiyan-dev avatar Sep 08 '22 04:09 sanjaiyan-dev

@sanjaiyan-dev no problem, I'll just pull the changes, and create a new branch with your commit on it. Thank you!

blittle avatar Sep 08 '22 21:09 blittle

@sanjaiyan-dev no problem, I'll just pull the changes, and create a new branch with your commit on it. Thank you!

Tks a lot 🤝

sanjaiyan-dev avatar Sep 09 '22 00:09 sanjaiyan-dev

Done 🤝

sanjaiyan-dev avatar Sep 17 '22 06:09 sanjaiyan-dev

Extremely sorry for disturbing, any update on this ?

@blittle

sanjaiyan-dev avatar Oct 01 '22 02:10 sanjaiyan-dev

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset. If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG. If you are making simple updates to examples or documentation, you do not need to add a changeset.

github-actions[bot] avatar Apr 10 '24 18:04 github-actions[bot]