hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Customer Account Oauth Login Page Ignores Store Branding

Open contrebande-labs opened this issue 1 year ago • 2 comments

What is the location of your example repository?

No response

Which package or tool is having this issue?

Other / I don't know

What version of that package or tool are you using?

Any

What version of Remix are you using?

Latest

Steps to Reproduce

Integrate the customer account client into your project or use the login on the demo store.

Expected Behavior

The login() method of the customer account API leads to a passwordless login page that takes into account the online store branding configured in the store admin: background color(s), text color, modal color, button color.

Actual Behavior

The login() method of the customer account API leads to a passwordless login page that ignores online store branding configured in the store admin.

contrebande-labs avatar Mar 23 '24 03:03 contrebande-labs

Hi @contrebande-labs this is high priority to resolve asap. I don't have an exact timeline to share, but it is coming soon.

blittle avatar Mar 25 '24 17:03 blittle

Hi @blittle. Thanks. Can you keep this issue updated so we can track the progress on a resolution?

contrebande-labs avatar Mar 25 '24 19:03 contrebande-labs

@contrebande-labs as a follow up, sadly this item had been de-prioritized till later this year (more likely in the Fall)

The announcement will come in either: https://changelog.shopify.com/ or https://shopify.dev/changelog

I am going to close this issue for now. But if you ask again in the future we can try to follow up as well.

michenly avatar May 09 '24 19:05 michenly

Well, this is doubly disappointing, why would you close the issue?

contrebande-labs avatar May 09 '24 20:05 contrebande-labs

Sadly this is not a hydrogen project issue that this small team who monitor this github project can expedite or do anything about beyond what we already did. I close it to keep the team focus on things we can action on.

michenly avatar May 09 '24 21:05 michenly

You should not maintain a client (the Customer Account API client) for the defective product as part of this project, then. I can't think of any business for whom this wouldn't be a problem. It makes it worth it for us to forego the Shopify checkout, login, tracking page, etc. entirely and develop something with Stripe and the Admin API directly.

contrebande-labs avatar May 09 '24 23:05 contrebande-labs

I dont disagree that CA API is missing some features. Since the login branding is of high importance to you however. My suggestion would be that you use the legacy customer account flow instead.

https://github.com/Shopify/hydrogen/tree/main/examples/legacy-customer-account-flow is where the code for this flow lives and there is a CLI command for scaffolding out a project with it in the README.

This flow uses the storefront API login flow and the example includes template for pages such as password login flow and order tracking page. Both you can style yourself to match the branding of your site.

michenly avatar May 14 '24 01:05 michenly

Thanks for the suggestion, @michenly. However, we are not going to write and maintain code for a soon-to-be deprecated legacy product. Also, it's not just the new customer account that is very badly integrated with headless storefronts, checkout is hardly interoperable with Hydrogen (see other issues I've participated in regarding that) and so are webpixels/trekkie/monorail tracking. We are fairly confident about the alternative implemementation we are currently building with Shopify Admin API, Stripe Elements and our own implementation of passwordless login. We are going to go with this for the moment.

contrebande-labs avatar May 14 '24 02:05 contrebande-labs

contrebande-labs I am glad you guys found a solution that works for you. I will certainly bring up your feedback to the appropriate team.

michenly avatar May 14 '24 14:05 michenly