hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard
verified publisher icon Shopify

[BUG] Incompatible Node versions in Hydrogen and CLI

Open frandiox opened this issue 3 years ago • 5 comments

We have engines set to Node 14 in Hydrogen itself, but mini-oxygen requires 16.7. This error is thrown when building with Node 14 (this is from Vercel build logs):

error @shopify/[email protected]: The engine "node" is incompatible with this module. Expected version ">16.7.0". Got "14.19.0"

mini-oxygen is a dependency of the new CLI and it's installed even if we are only targeting Node environments.

frandiox avatar Jun 24 '22 09:06 frandiox

Should we change Hydrogen to only be Node 16 and up?

blittle avatar Jul 01 '22 16:07 blittle

Should we change Hydrogen to only be Node 16 and up?

I think that was the original plan, but we were held back by Stackblitz at the time?

frehner avatar Jul 01 '22 16:07 frehner

Minor addition, Vite cannot run our Hydrogen app on node 14.16. When upgrading to Node 16 it does work. This happened only after the new additions in v1.0.0 of Hydrogen.

JaapWeijland avatar Jul 04 '22 11:07 JaapWeijland

@frandiox can we close this one? I think we've settled on supporting Node 16.5.0 or higher.

cartogram avatar Jul 27 '22 14:07 cartogram

I think we just need to make sure that we properly error/warn the user when they are using a non-supported version, instead of just dying.

blittle avatar Jul 27 '22 15:07 blittle