hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Cart doesnt properly close when clicking the grey space to the left of it

Open QuentinGibson opened this issue 2 years ago • 1 comments

What is the location of your example repository?

No response

Which package or tool is having this issue?

Other / I don't know

What version of that package or tool are you using?

Hydrogen Skeleton store

What version of Remix are you using?

1.17.1

Steps to Reproduce

Create a new store with these settings image

Expected Behavior

When the darken area is clicked the cart should close image

Actual Behavior

When the darken area is clicked the page is refreshed and the cart is still open

QuentinGibson avatar Jul 26 '23 23:07 QuentinGibson

The error happens in Ubuntu Firefox 115. I tested it in chrome and it worked just fine.

Also, removing the line window.location.hash = '' fixed the issue with Firefox

QuentinGibson avatar Jul 26 '23 23:07 QuentinGibson

Fixed in our new starter template, which no longer uses hash state opening and closing the cart, but uses react state instead.

blittle avatar Jun 21 '24 20:06 blittle