ejson2env icon indicating copy to clipboard operation
ejson2env copied to clipboard

Add option to trim leading underscore

Open shanesmith opened this issue 1 year ago • 6 comments

Keys with unencrypted values have a leading underscore. When exported to an env variable the underscore is preserved but can feel awkward to use on the system.

The new --trim-underscore flag is introduced and can be used to, you guessed it, trim the underscore from the exported env variable name.

The use of this flag makes ejson2env match Krane's behaviour of stripping the leading understore from secrets.

Fixes #17

shanesmith avatar Feb 21 '24 18:02 shanesmith

I have signed the CLA!

shanesmith avatar Feb 21 '24 18:02 shanesmith

@sambostock Hello! Noticed you were last to commit to this repo so hoping to snag a review from you! 🙏🏻

shanesmith avatar Feb 21 '24 18:02 shanesmith

@shanesmith -- Nice! @sambostock / @burke , happy to assist getting this over the line if anything is needed!

frison avatar Sep 24 '24 20:09 frison

@sambostock thanks for the ✅!

There seems to be an issue however in that CI is required to merge this PR but it doesn't run on the commit. This seems to be due to the CI triggering only on push, which includes only commits to this repo and not forked PRs like this.

I created https://github.com/Shopify/ejson2env/pull/87 to try to fix this issue, would be great if you could take a look. =)

shanesmith avatar Oct 01 '24 16:10 shanesmith

Much appreciated! All green now!

shanesmith avatar Oct 01 '24 19:10 shanesmith

@burke sorry to bother again, last time I promise, but I don't have a merge button, would you mind doing the honours?

shanesmith avatar Oct 03 '24 16:10 shanesmith

Done! Thanks!

burke avatar Oct 07 '24 19:10 burke