draggable icon indicating copy to clipboard operation
draggable copied to clipboard

[WIP] Add Pannable plugin

Open owen-m1 opened this issue 6 years ago • 2 comments

This PR implements or fixes...

Adds a Pannable plugin to Draggable, for panning around elements that have overflow in their parent container. Effectively making it a replacement for scrollbars.

This PR closes the following issues...

#309 …

Does this PR require the Docs to be updated?

Yes …

Does this PR require new tests?

Yes …

This branch been tested on... (click all that apply / add new items)

Browsers:

  • [ ] Chrome version
  • [ ] Firefox version
  • [ ] Safari version
  • [ ] IE / Edge version
  • [ ] iOS Browser version
  • [ ] Android Browser version

owen-m1 avatar Jul 17 '19 01:07 owen-m1

Hi @owen-m1,

I had a general suggestion. Seems like one commit is containing too much of a code changes. Could it be broken down into smaller frequent commits, so that the history is much easier to follow and review by commits?

Thanks.

itsmunim avatar Aug 28 '19 13:08 itsmunim

@dibosh I completely agree with you but I was following the PR guide which said to force-push to one commit. I don't like this either D:

owen-m1 avatar Aug 28 '19 15:08 owen-m1