type definition file

[haoliangwu]

[beefchimi]

Hey @haoliangwu , just curious why you closed https://github.com/Shopify/draggable/pull/112 and opened up this PR instead?

Did you have an issue rebasing off the latest master? If so, please don't hesitate to ping either myself or @tsov and we can help you. Its almost always better to keep the conversation / commit history from the original branch.

Also, would you mind providing a description for this PR?

Thanks!

[haoliangwu]

@beefchimi just the revision definition file according to tips of last PR, I resend the PR because the codebase of last one is not same as current one. But I am still sorry for opening a new issue without any description.

thanks.

[beefchimi]

What is the status of this? Does it still need work? Do we want to merge it? Has its time passed and we let it slip gently into the night?

@tsov / @haoliangwu please let me know.

[toebes]

I've taken a look at what @haoliangwu implemented and then compared to the latest version of Draggable to generate a new version at https://github.com/toebes/draggable/blob/master/index.d.ts
After looking at the Contributing guidelines I'm not sure whether it is better for me to make a new Pull request (referencing the work here and in #112 ) or whether I should put in a new pull request. I've tried to take into account all of the comments @TheMallen made in #112.

So what would be preferable? Generate a new pull request referencing this one or is there some other github pull approach that I should take?

Thanks!

[beefchimi]

@toebes I personally think its fine to open a new pull request and reference this one.

It would be great if we could maintain @haoliangwu contribution in the git history somehow (two authors on a single commit or two separate commits with one author on each) - if you can figure that out easily enough, go for it, otherwise lets see that PR!