deprecation_toolkit icon indicating copy to clipboard operation
deprecation_toolkit copied to clipboard

Include stacktrace in record behavior

Open harirajv opened this issue 3 years ago • 1 comments

Currently, the record DeprecationBehavior removes the stacktrace from the deprecation message before writing to YAML- https://github.com/Shopify/deprecation_toolkit/blob/main/lib/deprecation_toolkit/behaviors/record.rb#L11

This stacktrace is pretty useful info but it is removed from the YAML content - https://github.com/Shopify/deprecation_toolkit/blob/main/lib/deprecation_toolkit/collector.rb#L36

I am willing to submit a pull request that can change the behaviour, but would like to confirm why this done.

@Edouard-chin @rafaelfranca

harirajv avatar May 13 '22 10:05 harirajv

I'd also like to see this in CIRecordHelper. It might be good to default to just one line, but allow this to be controlled via config.

boardfish avatar Sep 06 '22 13:09 boardfish