Shopify
[Feature]: Ability to upload theme extensions from a `/dist` folder
What area(s) will this request affect?
Extension, Deployment
What type of change do you want to see?
Substantial change to existing feature
Overview
A way to deploy a theme extensions (or other extensions) from a specific folder that is generated after a build command has been executed.
Motivation
This is easily achiveable with CLI 2.x using a custom command e.g. npm run build (which generates a folder named /dist) and then running a command like cd dist and shopify extension push.
This allows us to use rollup or equivalent before the extension is pushed.
Hi @NexPB, thank you for opening this issue. @Shopify/theme-developer-tools would this be something for you?
@matteodepalo ~~afaik @Shopify/theme-developer-tools seems to be for themes in general this is for an existing app where I want to publish theme extensions, I was trying to migrate to Shopify CLI 3.x from 2.x~~
@Shopify/theme-developer-tools I cannot find this package anywhere?
Just to make sure I'm wanting to push a theme extensions for an app e.g.: app blocks and app embeds, not a theme for a shop.
👋 Hi @matteodepalo,
I don't think that @Shopify/theme-developer-tools has so much context on that.
My understanding is that this issue is a proposal to support a different directory structure in a app. Thus, the app deploy command (which is the new command that replaces shopify extension push) would support deploying an extension from a /dist directory. Is that correct, @NexPB?
As explained here, when running deploy, the CLI is building the extensions in a temporary directory.
So to achieve this, I guess we could add a new optional field to the shopify.*.extension.toml files like deploy_directory = "dist" to use that content when present instead of building.
cc: @stephszeto
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
So to achieve this, I guess we could add a new optional field to the shopify.*.extension.toml files like deploy_directory = "dist" to use that content when present instead of building
This makes sense to me - will see where we can slot this into our roadmap! Thanks for raising!
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
Today we could not publish a theme-extension release for one of our apps (since the admin dashboard flow does not detect the latest changes when we make a release), some help would be appreciated.
This app still relies on the old shopfy cli 2.0 flow which easily supported this flow... some urgency would be appreciated :')
@github-actions github-actions bot closed this as completed on Aug 22, 2023
How did this get completed?
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
@pauldraper is your purpose here to publish/deploy just one extension rather than several? If so - we are in the same boat. Would like to see that functionality.
No, that's not my purpose.
My purpose is running TS/rollup/webpack on scripts