cli icon indicating copy to clipboard operation
cli copied to clipboard

Allow to create contract-based specifications with some local overrides

Open isaacroldan opened this issue 1 month ago β€’ 3 comments

WHY are these changes introduced?

Refactors the createContractBasedModuleSpecification function to accept a single object parameter instead of multiple arguments, making the API more flexible and consistent.

WHAT is this pull request doing?

  • Modifies createContractBasedModuleSpecification to accept a configuration object with identifier, appModuleFeatures, and buildConfig properties
  • Updates all calls to this function throughout the codebase
  • Simplifies the channel specification implementation by leveraging the contract-based module specification

How to test your changes?

  1. Run the extension specification tests to ensure they pass
  2. Create a new channel extension to verify the specification works correctly
  3. Verify that existing extensions using contract-based module specifications continue to function properly

Measuring impact

How do we know this change was effective? Please choose one:

  • [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes

isaacroldan avatar Nov 17 '25 11:11 isaacroldan

This stack of pull requests is managed by Graphite. Learn more about stacking.

isaacroldan avatar Nov 17 '25 11:11 isaacroldan

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

github-actions[bot] avatar Nov 17 '25 11:11 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.25% (+0.02% πŸ”Ό)
13582/17139
🟑 Branches
73.14% (+0.03% πŸ”Ό)
6632/9068
🟑 Functions
79.41% (+0.04% πŸ”Ό)
3505/4414
🟑 Lines
79.6% (+0.02% πŸ”Ό)
12828/16116
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟑
... / specification.ts
68.52% (-0.57% πŸ”»)
74.36% (+1.19% πŸ”Ό)
76.47% (-1.31% πŸ”»)
68.09% (-0.66% πŸ”»)

Test suite run success

3356 tests passing in 1372 suites.

Report generated by πŸ§ͺjest coverage report action from 9ae216cec1ebf904db2266f3a0a0fb41fdb57f6a

github-actions[bot] avatar Nov 17 '25 11:11 github-actions[bot]