cli icon indicating copy to clipboard operation
cli copied to clipboard
verified publisher icon Shopify

Restore usage of custom app passwords to theme commands

Open graygilmore opened this issue 1 month ago • 4 comments

WHY are these changes introduced?

  • Closes https://github.com/Shopify/cli/issues/6415

This was previously stripped away but theme developers are still using this flow and are forced to pin to older versions. I'm returning the functionality in this PR but calling out the specific places where it doesn't work:

  • dev does not support hot module reloading
  • console and profile commands do not work at all

I tested on all of the theme commands:

check - ✅
console - ❌
delete - ✅
dev - 🟡 
duplicate - ✅
info - ✅
init - ✅
language-server - ✅
list - ✅
open - ✅
package - ✅
profile - ❌
publish - ✅
pull - ✅
push - ✅
rename - ✅
share - ✅

For console and profile we now throw an AbortError. For dev we render a warning.

How to test your changes?

  1. Install the snapped version npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]
  2. Run through as many of the commands as you'd like to test

graygilmore avatar Nov 14 '25 22:11 graygilmore

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🟡 Statements
79.2% (-0.02% 🔻)
 13647/17230
🟡 Branches
73.05% (-0.05% 🔻)
 6648/9100
🟡 Functions
79.36% (-0.01% 🔻)
 3518/4433
🟡 Lines
79.57% (-0.02% 🔻)
 12892/16203
Show new covered files 🐣
St.:grey_question:
 File Statements Branches Functions Lines
🟢
... / bulk-operation-run-mutation.ts
 100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
 100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
 100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
 95.24% 85.71% 100% 95%
🟢
... / run-mutation.ts
 100% 100% 100% 100%
🟢
... / run-query.ts
 100% 100% 100% 100%
🟡
... / stage-file.ts
 74.29% 53.33% 85.71% 73.53%
Show files with reduced coverage 🔻
St.:grey_question:
 File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
 100%
98.33% (-1.67% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
12.77% (-0.57% 🔻)
2.78% (-0.16% 🔻)
 57.14%
12.77% (-0.57% 🔻)
🟡
... / theme-environment.ts
69.57% (-1.86% 🔻)
 50%
55.56% (-3.27% 🔻)
69.57% (-1.86% 🔻)

Test suite run success

3365 tests passing in 1377 suites.

Report generated by 🧪jest coverage report action from 56c08f7c089b0c7e36537c0575a5096bd31379da

github-actions[bot] avatar Nov 14 '25 23:11 github-actions[bot]

/snapit

graygilmore avatar Nov 14 '25 23:11 graygilmore

🫰✨ Thanks @graygilmore! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Nov 14 '25 23:11 github-actions[bot]

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

github-actions[bot] avatar Nov 14 '25 23:11 github-actions[bot]

Force Push Patch Notes

  • Updated to note that password protected storefronts also don't work

Thanks to both @dejmedus and @EvilGenius13 for the tophatting 😄

graygilmore avatar Nov 21 '25 23:11 graygilmore