cli icon indicating copy to clipboard operation
cli copied to clipboard

Remove legacy app schema

Open gonzaloriestra opened this issue 1 month ago β€’ 1 comments

WHY are these changes introduced?

⚠️ These PRs for the templates must be merged first (the acceptance tests will pass then):

  • https://github.com/Shopify/shopify-app-template-react-router/pull/127
  • https://github.com/Shopify/shopify-app-template-none/pull/24

The subscriptions-reference-app template is ready, and I guess there's no need to update old templates like Remix, Node, Ruby or PHP templates.

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

gonzaloriestra avatar Nov 12 '25 13:11 gonzaloriestra

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.26% (+0.03% πŸ”Ό)
13564/17114
🟑 Branches
73.14% (+0.03% πŸ”Ό)
6610/9038
🟑 Functions
79.34% (-0.03% πŸ”»)
3502/4414
🟑 Lines
79.61% (+0.03% πŸ”Ό)
12813/16094
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / app.test-data.ts
91.88% (-0.16% πŸ”»)
94.59% (+0.68% πŸ”Ό)
82.35% (-0.21% πŸ”»)
91.26% (-0.19% πŸ”»)
🟒
... / app.ts
88.02% (+1.39% πŸ”Ό)
68.97% (+0.39% πŸ”Ό)
93.33% (-0.32% πŸ”»)
88.59% (+0.25% πŸ”Ό)
🟒
... / loader.ts
93.15% (-0.71% πŸ”»)
84.66% (-2.17% πŸ”»)
97.06%
93.65% (-1.02% πŸ”»)
🟒
... / common.ts
87.5% (-12.5% πŸ”»)
88.89% (-11.11% πŸ”»)
100% 100%
🟒
... / app-context.ts
96.55% (-0.11% πŸ”»)
89.47% (-1.83% πŸ”»)
100%
96.43% (-0.12% πŸ”»)
πŸ”΄
... / dev.ts
16.54% (-0.65% πŸ”»)
16.44% (-0.89% πŸ”»)
19.44%
16.95% (-0.7% πŸ”»)
🟒
... / link.ts
96.34% (-0.17% πŸ”»)
95.16% (-0.29% πŸ”»)
100%
96.15% (-0.19% πŸ”»)
🟒
... / ConcurrentOutput.tsx
98.36% (-1.64% πŸ”»)
92% (-4% πŸ”»)
100%
98.33% (-1.67% πŸ”»)
🟒
... / string.ts
93.22% (-1.69% πŸ”»)
79.17% (-4.17% πŸ”»)
95.65% 96.08%
πŸ”΄
... / dev.ts
13.04% (-0.29% πŸ”»)
2.94% 57.14%
13.04% (-0.29% πŸ”»)
🟒
... / theme-uploader.ts
91.84% (+0.12% πŸ”Ό)
78.21% (-0.83% πŸ”»)
86.36% (-1.14% πŸ”»)
93.18% (+0.59% πŸ”Ό)
🟑
... / theme-environment.ts
70.45% (-0.97% πŸ”»)
50%
57.89% (-0.93% πŸ”»)
70.45% (-0.97% πŸ”»)

Test suite run success

3347 tests passing in 1371 suites.

Report generated by πŸ§ͺjest coverage report action from 3cc6b58f20749ae9c400ada05a2b86be1ea54306

github-actions[bot] avatar Nov 12 '25 13:11 github-actions[bot]