cli icon indicating copy to clipboard operation
cli copied to clipboard

wip

Open ryancbahan opened this issue 1 month ago • 2 comments

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

ryancbahan avatar Nov 11 '25 00:11 ryancbahan

Unused files (1)

packages/cli-kit/src/private/node/api/graphql/business-platform-destinations/user-email.ts

Unused types (1)

Filename types
packages/cli-kit/src/private/node/session/exchange.ts ExchangeScopes

github-actions[bot] avatar Nov 11 '25 00:11 github-actions[bot]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/session.d.ts
@@ -1,4 +1,9 @@
 import { AdminSession } from '../../public/node/session.js';
+/**
+ * Fetches the user's email from the Business Platform API
+ * @param businessPlatformToken - The business platform token
+ * @returns The user's email address or undefined if not found
+ */
 /**
  * A scope supported by the Shopify Admin API.
  */
@@ -103,5 +108,11 @@ export interface EnsureAuthenticatedAdditionalOptions {
  * @param options - Optional extra options to use.
  * @returns An instance with the access tokens organized by application.
  */
-export declare function ensureAuthenticated(applications: OAuthApplications, _env?: NodeJS.ProcessEnv, { forceRefresh, noPrompt, forceNewSession }?: EnsureAuthenticatedAdditionalOptions): Promise<OAuthSession>;
-export {};
\ No newline at end of file
+export declare function ensureAuthenticated(_applications: OAuthApplications, _env?: NodeJS.ProcessEnv, { _forceRefresh, _noPrompt, _forceNewSession }?: any): Promise<OAuthSession>;
+export {};
+/**
+ * Get a flattened array of scopes for the given applications.
+ *
+ * @param apps - An object containing the applications we need the scopes for.
+ * @returns A flattened array of scopes.
+ */
\ No newline at end of file

packages/cli-kit/dist/private/node/session/exchange.d.ts
@@ -61,7 +61,7 @@ type IdentityDeviceError = 'authorization_pending' | 'access_denied' | 'expired_
  * @param scopes - The scopes to request
  * @returns An instance with the identity access tokens.
  */
-export declare function exchangeDeviceCodeForAccessToken(deviceCode: string): Promise<Result<IdentityToken, IdentityDeviceError>>;
+export declare function exchangeDeviceCodeForAccessToken(_deviceCode?: string): Promise<Result<IdentityToken, IdentityDeviceError>>;
 export declare function requestAppToken(api: API, token: string, scopes?: string[], store?: string): Promise<{
     [x: string]: ApplicationToken;
 }>;

github-actions[bot] avatar Nov 11 '25 00:11 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Dec 11 '25 03:12 github-actions[bot]