cli icon indicating copy to clipboard operation
cli copied to clipboard

add dynamic batching and catching on ssl error

Open EvilGenius13 opened this issue 2 months ago β€’ 5 comments

🚧 SNAP BUILD TESTING 🚧

EvilGenius13 avatar Oct 24 '25 18:10 EvilGenius13

Unused exports (1)

Filename exports
packages/theme/src/cli/utilities/theme-uploader.ts MIN_BATCH_FILE_COUNT

github-actions[bot] avatar Oct 24 '25 18:10 github-actions[bot]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -2,6 +2,7 @@ export declare const logsFolder: () => string;
 export declare const environmentVariables: {
     alwaysLogAnalytics: string;
     alwaysLogMetrics: string;
+    badssl: string;
     deviceAuth: string;
     enableCliRedirect: string;
     env: string;

packages/cli-kit/dist/public/node/context/local.d.ts
@@ -166,4 +166,11 @@ export declare function getThemeKitAccessDomain(env?: NodeJS.ProcessEnv): string
  * @returns The domain to send OTEL metrics to.
  */
 export declare function opentelemetryDomain(env?: NodeJS.ProcessEnv): string;
+/**
+ * Returns true if badssl mode is enabled.
+ *
+ * @param env - The environment variables from the environment of the current process.
+ * @returns True if SHOPIFY_CLI_BADSSL is truthy.
+ */
+export declare function badsslEnabled(env?: NodeJS.ProcessEnv): boolean;
 export type CIMetadata = Metadata;
\ No newline at end of file

github-actions[bot] avatar Oct 24 '25 19:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.14% (-0.08% πŸ”»)
13471/17022
🟑 Branches
72.95% (-0.1% πŸ”»)
6563/8997
🟑 Functions
79.2% (-0.04% πŸ”»)
3466/4376
🟑 Lines
79.5% (-0.08% πŸ”»)
12730/16012
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / git.ts
91.92% (-0.46% πŸ”»)
88% (-1.29% πŸ”»)
90.48%
92.71% (-0.43% πŸ”»)
🟑
... / local.ts
68.63% (-1.37% πŸ”»)
56.25% (-1.2% πŸ”»)
54.55% (-2.6% πŸ”»)
68.63% (-1.37% πŸ”»)
🟒
... / theme-uploader.ts
84.08% (-7.63% πŸ”»)
66.67% (-12.37% πŸ”»)
86.15% (-1.35% πŸ”»)
84.53% (-8.06% πŸ”»)

Test suite run success

3311 tests passing in 1359 suites.

Report generated by πŸ§ͺjest coverage report action from 8f4785558bbae890f40ac2b91875d1355ff048f3

github-actions[bot] avatar Oct 24 '25 19:10 github-actions[bot]

/snapit

EvilGenius13 avatar Oct 24 '25 19:10 EvilGenius13

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Oct 24 '25 19:10 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Nov 24 '25 03:11 github-actions[bot]