cli icon indicating copy to clipboard operation
cli copied to clipboard

Update Ink and React dependencies

Open isaacroldan opened this issue 2 months ago • 7 comments

WHY are these changes introduced?

Upgrade TypeScript configuration and React to version 19.1.0 to leverage newer language features and improve performance.

WHAT is this pull request doing?

  • Updates TypeScript configuration in tsconfig.json to use ES2023 and Bundler module resolution
  • Upgrades React from 17.0.2/18.x to 19.1.0 across all packages
  • Upgrades Ink from 4.4.1 to 6.3.1 for compatibility with React 19
  • Updates React-related type definitions to match the new version
  • Fixes ignore module imports to use the direct import syntax

How to test your changes?

  1. Run the test suite to ensure all tests pass with the new React version
  2. Test the CLI functionality to verify it works correctly with the updated dependencies
  3. Verify that the bundled output works as expected with the splitting disabled

Measuring impact

How do we know this change was effective? Please choose one:

  • [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes

isaacroldan avatar Oct 17 '25 10:10 isaacroldan

This stack of pull requests is managed by Graphite. Learn more about stacking.

isaacroldan avatar Oct 17 '25 10:10 isaacroldan

/snapit

isaacroldan avatar Oct 17 '25 10:10 isaacroldan

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

github-actions[bot] avatar Oct 17 '25 10:10 github-actions[bot]

/snapit

isaacroldan avatar Oct 17 '25 10:10 isaacroldan

/snapit

isaacroldan avatar Oct 17 '25 12:10 isaacroldan

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/error.d.ts
@@ -38,8 +38,6 @@ export declare abstract class FatalError extends Error {
  * Those usually represent unexpected scenarios that we can't handle and that usually require some action from the developer.
  */
 export declare class AbortError extends FatalError {
-    nextSteps?: TokenItem<InlineToken>[];
-    customSections?: AlertCustomSection[];
     constructor(message: TokenItem | OutputMessage, tryMessage?: TokenItem | OutputMessage | null, nextSteps?: TokenItem<InlineToken>[], customSections?: AlertCustomSection[]);
 }
 /**

github-actions[bot] avatar Oct 17 '25 15:10 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Nov 17 '25 03:11 github-actions[bot]