cli icon indicating copy to clipboard operation
cli copied to clipboard

turn off keep alive test for bad mac error

Open EvilGenius13 opened this issue 2 months ago β€’ 6 comments

🚧 Keep Alive test 🚧

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

EvilGenius13 avatar Oct 16 '25 15:10 EvilGenius13

/snapit

EvilGenius13 avatar Oct 16 '25 15:10 EvilGenius13

🫰✨ Thanks @EvilGenius13! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Oct 16 '25 15:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
79.02% (+0% πŸ”Ό)
13359/16906
🟑 Branches
72.72% (-0.01% πŸ”»)
6526/8974
🟑 Functions
79.21% (+0.03% πŸ”Ό)
3449/4354
🟑 Lines
79.38% (-0.01% πŸ”»)
12621/15899
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
πŸ”΄
... / theme-ui.ts
59.09% (-27.27% πŸ”»)
38.89% (-24.27% πŸ”»)
60% (-20% πŸ”»)
59.09% (-27.27% πŸ”»)

Test suite run success

3279 tests passing in 1346 suites.

Report generated by πŸ§ͺjest coverage report action from c4a90a157ef79c8ada6d433a84fc4d4e6db6ad74

github-actions[bot] avatar Oct 16 '25 15:10 github-actions[bot]

if this is related to the report/pr I submitted at https://github.com/Shopify/cli/pull/6516, FYI turning off keepalive didn't fix the issue for me - I tried that first.

trwww avatar Oct 16 '25 15:10 trwww

if this is related to the report/pr I submitted at #6516, FYI turning off keepalive didn't fix the issue for me - I tried that first.

Thank you for the information! We've been trying a couple of options related to this.

EvilGenius13 avatar Oct 16 '25 17:10 EvilGenius13

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Nov 16 '25 03:11 github-actions[bot]