cli icon indicating copy to clipboard operation
cli copied to clipboard

[Feature]: Update @shopify/cli-kit to support ink v5/v6 for React 19 compatibility

Open juanpprieto opened this issue 3 months ago • 3 comments

What area(s) will this request affect?

Hydrogen custom storefront

What type of change do you want to see?

Substantial change to existing feature

Overview

The Hydrogen team needs to migrate to React 19 to maintain compatibility with React Router 7.8.x and support the latest React features. However, we're currently blocked because @shopify/[email protected] depends on [email protected], which only supports React 18.

Current situation:

  • @shopify/cli-kit requires [email protected] (React 18 only)
  • Hydrogen needs React 19 for React Router 7.8.x compatibility
  • This creates a version conflict in the monorepo

Good news - ink already supports React 19:

Motivation

Why this matters for Hydrogen:

  1. React Router 7.8.x compatibility: React Router 7.8.x serves as a bridge from React 18 to React 19, and we need to support React 19 throughout the Hydrogen monorepo
  2. Ecosystem alignment: The React ecosystem is moving to React 19, and Hydrogen needs to stay current
  3. Developer experience: Currently, developers face React version conflicts when trying to upgrade Hydrogen CLI and other hydrogen packages to React 19.

juanpprieto avatar Sep 02 '25 16:09 juanpprieto

@juanpprieto could you create a PR upgrading ink? If this is urgent for your team that'd be the fastest way 🙏

isaacroldan avatar Sep 17 '25 09:09 isaacroldan

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Oct 30 '25 03:10 github-actions[bot]

hey @juanpprieto is this still relevant and/or urgent? can your team own it?

isaacroldan avatar Oct 30 '25 10:10 isaacroldan