Shopify
Use shop.dev, not my.shop.dev, for shopify
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.
[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 76.62% (-0.01% 🔻) |
9588/12514 |
| 🟡 | Branches | 71.89% (-0.07% 🔻) |
4729/6578 |
| 🟡 | Functions | 76.56% | 2485/3246 |
| 🟡 | Lines | 77.13% (-0.01% 🔻) |
9061/11748 |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / link.ts |
96.55% | 92.42% (-0.43% 🔻) |
100% | 96.39% |
| 🟢 | ... / mkcert.ts |
93.33% (-3.28% 🔻) |
76% (-7.87% 🔻) |
100% | 93.02% (-5.22% 🔻) |
| 🔴 | ... / app-management-client.ts |
41.78% (-0.4% 🔻) |
36.75% (-2.59% 🔻) |
40% | 40.37% (-0.44% 🔻) |
| 🟢 | ... / ConcurrentOutput.tsx |
98.36% (-1.64% 🔻) |
88% (-4% 🔻) |
100% | 98.33% (-1.67% 🔻) |
| 🟢 | ... / version.ts |
88.89% (-0.58% 🔻) |
90% | 100% | 87.5% (-0.74% 🔻) |
Test suite run success
2252 tests passing in 981 suites.
Report generated by 🧪jest coverage report action from 6a9ac275b16f9f6d72125b033c40b63ab54d2690
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
The original dev-server package still has the my.shop.dev value. Is there a plan to update it there?
@isaacroldan I am not sure and I did not spend the time to bug the team in charge of DevServer because the CLI started to work, [for me], out of the box, without this patch.
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.