Add trampoline run on wasm modules as part of function build
@lopert had most of the work done, I added some tests, cleanup and fixed the download package path.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-shopifyvm/issues/28
We need to apply the trampolining process to guest modules using the Wasm API to allow for it to copy data between the memory of the provider and guest modules.
WHAT is this pull request doing?
Downloading the trampoline release from github and run trampoline with input as function.wasm file during function build.
How to test your changes?
pnpm run shopify app function build --path <full path to your functions app> --verbose
verbose let me see that all the download and apply trampoline commands succeeded.
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [x] I've considered possible documentation changes
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 76.77% (+0.03% πΌ) |
9667/12592 |
| π‘ | Branches | 72.12% (+0.04% πΌ) |
4785/6635 |
| π‘ | Functions | 76.6% (+0.01% πΌ) |
2495/3257 |
| π‘ | Lines | 77.28% (+0.03% πΌ) |
9138/11824 |
Test suite run success
2289 tests passing in 990 suites.
Report generated by π§ͺjest coverage report action from 488c549519acb8dbfca60492ae8dd6bdce0c1e7f
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.
[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.
Re-requesting reviews because I added a minor version changeset.