Use Javy Plugin v2
We need to release the functions JS package before we merge this.
WHY are these changes introduced?
Part of https://github.com/shop/issues-shopifyvm/issues/29
WHAT is this pull request doing?
Uses the new version of the javy plugin, as well as updating the related npm package accepted versions.
How to test your changes?
Without this branch, create a function extension from a javascript template.
Repeat the same with this branch.
Make sure to npm install both.
With this branch, attempt to build the two functions.
pnpm shopify app function build --path /path/to/javascript/extension
On the first extension, it should fail, because it's package.json depends on "@shopify/shopify_function": "~1.0.0" which no longer matches our minimum accepted version.
On the second extension, it should succeed, because it's package.json depends on "@shopify/shopify_function": "~2.0.0".
You can check out main and attempt the build commands again to see the inverse behaviour.
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 76.63% | 9601/12529 |
| π‘ | Branches | 71.96% | 4750/6601 |
| π‘ | Functions | 76.56% | 2485/3246 |
| π‘ | Lines | 77.14% | 9073/11762 |
Show files with reduced coverage π»
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π’ | ... / ConcurrentOutput.tsx |
98.36% (-1.64% π») |
88% (-4% π») |
100% | 98.33% (-1.67% π») |
Test suite run success
2271 tests passing in 983 suites.
Report generated by π§ͺjest coverage report action from a7876deae2d5acd729865bd6673d819a9ccb2154
I created a snapshot of the function JS package and then a snapshot of this branch with the function JS snapshot to test this change. To test everything end to end use @shopify/[email protected] for creating, building and running a function locally.
NOTE: the snapshot version starts with major version 0 so I had to modify preferred package version in my CLI snapshot to be 0, but everything else is the same.
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.
[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.
Closing in favor of https://github.com/Shopify/cli/pull/5790