cli icon indicating copy to clipboard operation
cli copied to clipboard

[DNM] PR to look at -- Rough prototype for extension sourcemaps

Open shauns opened this issue 1 year ago β€’ 2 comments

Opening PR for a place to put comments.

shauns avatar Oct 08 '24 08:10 shauns

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Oct 08 '24 08:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
72.55% (-0.18% πŸ”»)
8520/11743
🟑 Branches
69.52% (-0.18% πŸ”»)
4177/6008
🟑 Functions
71.61% (-0.09% πŸ”»)
2205/3079
🟑 Lines
72.87% (-0.2% πŸ”»)
8062/11064
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / loader.ts
94.35% (-0.03% πŸ”»)
86.21% (+0.41% πŸ”Ό)
98% (-0.02% πŸ”»)
95.38% (-0.03% πŸ”»)
🟒
... / extension-instance.ts
80.69% (-4.71% πŸ”»)
73.83% (-1.41% πŸ”»)
91.3%
81.62% (-5.1% πŸ”»)
🟒
... / specification.ts
93.1% (-1.81% πŸ”»)
90.48%
87.5% (-0.5% πŸ”»)
92% (-2.12% πŸ”»)
🟒
... / context.ts
91.7% (-0.03% πŸ”»)
87.28% 88.57%
92.65% (-0.03% πŸ”»)
πŸ”΄
... / dev.ts
9.65% (-10.35% πŸ”»)
1.56% (-13.36% πŸ”»)
15.79% (-8.6% πŸ”»)
9.52% (-11.35% πŸ”»)
🟑
... / local-storage.ts
69.44% (-1.61% πŸ”»)
57.14% (-5.36% πŸ”»)
72.73%
67.65% (-1.8% πŸ”»)
🟒
... / link.ts
96.51% (-0.08% πŸ”»)
91.94% (-0.25% πŸ”»)
100%
96.39% (-0.09% πŸ”»)
🟑
... / update-extension.ts
64.86% (-1.8% πŸ”»)
54.55% 60%
68.75% (-2.22% πŸ”»)

Test suite run success

1938 tests passing in 873 suites.

Report generated by πŸ§ͺjest coverage report action from 0a0f80e2696e10990a62d57b2b71862d04b15fd8

github-actions[bot] avatar Oct 08 '24 08:10 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Nov 08 '24 03:11 github-actions[bot]