Shopify
remove [object Object] from theme push --json warning message
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-advanced-edits/issues/357
When using the --json flag on shopify theme push, if there is an error, we are getting [object Object] as part of the output.
WHAT is this pull request doing?
Making a small change to only output the theme.name since it's all that's required for the warning message.
Before:
After:
How to test your changes?
pull down the branch fix-issue-357
build the branch
break any .json file
run theme push --json
Measuring impact
How do we know this change was effective? Please choose one:
- [X] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [X] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [X] I've considered possible documentation changes
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
- Themes: @shopify/advanced-edits
- UI extensions: @shopify/ui-extensions-cli
- Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
- Hydrogen: @shopify/hydrogen
- Other: @shopify/app-inner-loop
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.72% (+0.05% 🔼) |
8562/11774 |
| 🟡 | Branches | 69.71% (+0.07% 🔼) |
4204/6031 |
| 🟡 | Functions | 71.69% (-0.03% 🔻) |
2211/3084 |
| 🟡 | Lines | 73.05% (+0.05% 🔼) |
8104/11094 |
Show new covered files 🐣
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / function-upload-url-generate.ts |
100% | 100% | 100% | 100% |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / app.test-data.ts |
91.4% (-0.45% 🔻) |
91.09% | 81.01% (-1.04% 🔻) |
90.8% (-0.47% 🔻) |
| 🟢 | ... / app.ts |
87.07% | 70.89% (-0.72% 🔻) |
92% | 88.37% |
| 🟢 | ... / specification.ts |
93.1% (-1.81% 🔻) |
90.48% | 87.5% (-0.5% 🔻) |
92% (-2.12% 🔻) |
| 🟢 | ... / function.ts |
86.36% (-0.59% 🔻) |
86.36% | 83.33% | 86.36% (-0.59% 🔻) |
| 🟡 | ... / update-extension.ts |
64.86% (-5.14% 🔻) |
54.55% (-3.79% 🔻) |
60% | 68.75% (-5.54% 🔻) |
| 🟡 | ... / build.ts |
74.49% | 59.09% (-2.27% 🔻) |
75.76% | 72.22% |
| 🔴 | ... / app-management-client.ts |
20.75% (-0.09% 🔻) |
10.26% | 22.58% (-0.25% 🔻) |
19% (-0.09% 🔻) |
| 🔴 | ... / partners-client.ts |
26.87% (-0.2% 🔻) |
40% | 18.18% (-0.34% 🔻) |
26.56% (-0.21% 🔻) |
| 🟡 | ... / fs.ts |
62.5% | 84.62% (-7.05% 🔻) |
58.97% | 62.5% |
Test suite run success
1947 tests passing in 876 suites.
Report generated by 🧪jest coverage report action from a38952cd6c518428702db6be52cba3de8e5bda80
🚀 Nice!
Non blocking, but maybe we can wrap the theme name like this:
"The theme 'modern-contrast' was pushed with errors"Stands out more that way
Fixed!