cli icon indicating copy to clipboard operation
cli copied to clipboard

[Theme] Show preview url for gift cards in the initial server logs

Open frandiox opened this issue 1 year ago โ€ข 3 comments

WHY are these changes introduced?

The gift card preview URL is somewhat unknown. With this, we start showing it in the initial server logs:

image

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

frandiox avatar Oct 04 '24 06:10 frandiox

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Oct 04 '24 06:10 github-actions[bot]

@karreiro I'm not sure what you meant with handling the /123/preview in the backend but we can keep the conversation here and iterate ๐Ÿ™

frandiox avatar Oct 04 '24 06:10 frandiox

Coverage report

St.:grey_question:
Category Percentage Covered / Total
๐ŸŸก Statements
72.73% (+0.02% ๐Ÿ”ผ)
8563/11774
๐ŸŸก Branches
69.72% (+0.03% ๐Ÿ”ผ)
4205/6031
๐ŸŸก Functions 71.69% 2211/3084
๐ŸŸก Lines
73.06% (+0.02% ๐Ÿ”ผ)
8105/11094

Test suite run success

1947 tests passing in 876 suites.

Report generated by ๐Ÿงชjest coverage report action from 4f1e612030494520a060716b199eb046710e5bc7

github-actions[bot] avatar Oct 04 '24 06:10 github-actions[bot]