cli icon indicating copy to clipboard operation
cli copied to clipboard

[Themes] Add CLI environment configuration to exported pull, push, and findOrSelectTheme

Open jamesmengo opened this issue 1 year ago β€’ 2 comments

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-advanced-edits/issues/356

WHAT is this pull request doing?

Implements CLI environment configuration for programatic invocation of theme push, theme pull, and findOrSelectTheme

How to test your changes?

To test these changes:

  • Modify the value of options.verbose or options.noColor and run the command WITHOUT the flag
  • You should see the desired effects.

Post-release steps

No post-release steps are required for this change.

Measuring impact

How do we know this change was effective? Please choose one:

  • [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

jamesmengo avatar Oct 04 '24 03:10 jamesmengo

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Oct 04 '24 03:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 72.51% 8366/11538
🟑 Branches 69.09% 4111/5950
🟑 Functions 71.78% 2187/3047
🟑 Lines 72.81% 7909/10863
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / ConcurrentOutput.tsx
98.39% (-1.61% πŸ”»)
90.91% (-4.55% πŸ”»)
100%
98.33% (-1.67% πŸ”»)

Test suite run success

1903 tests passing in 865 suites.

Report generated by πŸ§ͺjest coverage report action from 4bbdc4ff801870d7fc370248acc053ddcdd2dfd3

github-actions[bot] avatar Oct 04 '24 03:10 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Oct 11 '24 16:10 github-actions[bot]