Shopify
[Themes] Remove Ruby from `theme pull` command
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-advanced-edits/issues/351
WHAT is this pull request doing?
- Removes
legacyflag fromtheme push - Removes Ruby Invocation from
theme push
How to test your changes?
- Try running with
--legacyflag -> this shouldn't return an error message
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [x] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [x] I've considered possible documentation changes
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
- Themes: @shopify/advanced-edits
- UI extensions: @shopify/ui-extensions-cli
- Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
- Hydrogen: @shopify/hydrogen
- Other: @shopify/app-inner-loop
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.6% (-0.07% 🔻) |
8520/11735 |
| 🟡 | Branches | 69.55% (-0.1% 🔻) |
4177/6006 |
| 🟡 | Functions | 71.61% (-0.11% 🔻) |
2205/3079 |
| 🟡 | Lines | 72.92% (-0.09% 🔻) |
8062/11056 |
Show new covered files 🐣
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / function-upload-url-generate.ts |
100% | 100% | 100% | 100% |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / app.test-data.ts |
91.4% (-0.45% 🔻) |
91.09% | 81.01% (-1.04% 🔻) |
90.8% (-0.47% 🔻) |
| 🟢 | ... / app.ts |
87.07% | 70.89% (-0.72% 🔻) |
92% | 88.37% |
| 🟢 | ... / loader.ts |
94.35% (-0.03% 🔻) |
86.21% (+0.41% 🔼) |
98% (-0.02% 🔻) |
95.38% (-0.03% 🔻) |
| 🟢 | ... / specification.ts |
93.1% (-1.81% 🔻) |
90.48% | 87.5% (-0.5% 🔻) |
92% (-2.12% 🔻) |
| 🟢 | ... / function.ts |
86.36% (-0.59% 🔻) |
86.36% | 83.33% | 86.36% (-0.59% 🔻) |
| 🟢 | ... / context.ts |
91.7% (-0.03% 🔻) |
87.28% | 88.57% | 92.65% (-0.03% 🔻) |
| 🔴 | ... / dev.ts |
9.65% (-10.35% 🔻) |
1.56% (-13.36% 🔻) |
15.79% (-8.6% 🔻) |
9.52% (-11.35% 🔻) |
| 🟡 | ... / local-storage.ts |
69.44% (-1.61% 🔻) |
57.14% (-5.36% 🔻) |
72.73% | 67.65% (-1.8% 🔻) |
| 🟢 | ... / link.ts |
96.51% (-0.08% 🔻) |
91.94% (-0.25% 🔻) |
100% | 96.39% (-0.09% 🔻) |
| 🟡 | ... / update-extension.ts |
64.86% (-5.14% 🔻) |
54.55% (-3.79% 🔻) |
60% | 68.75% (-5.54% 🔻) |
| 🟡 | ... / build.ts |
74.49% | 59.09% (-2.27% 🔻) |
75.76% | 72.22% |
| 🔴 | ... / app-management-client.ts |
20.75% (-0.09% 🔻) |
10.26% | 22.58% (-0.25% 🔻) |
19% (-0.09% 🔻) |
| 🔴 | ... / partners-client.ts |
26.87% (-0.2% 🔻) |
40% | 18.18% (-0.34% 🔻) |
26.56% (-0.21% 🔻) |
Test suite run success
1938 tests passing in 873 suites.
Report generated by 🧪jest coverage report action from 6697412eee6f99e351455d5ddef94921d215eacc
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.