cli icon indicating copy to clipboard operation
cli copied to clipboard

[Themes] Remove Ruby from `theme console` command

Open jamesmengo opened this issue 4 months ago • 3 comments

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-advanced-edits/issues/350

WHAT is this pull request doing?

This pull request focuses on cleaning up and simplifying the Console class in the theme package by removing deprecated and unused code. The most important changes include removing unnecessary imports, flags, and methods related to legacy implementations and port handling.

Code Cleanup and Simplification:

  • Removes Ruby CLI2 invocations from the theme console command
  • Removes legacy and port flags

How to test your changes?

  • Run the command with the legacy or port flags

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [x] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes

cc: @Shopify/advanced-edits

jamesmengo avatar Oct 01 '24 20:10 jamesmengo